[Patch, fortran] PR24325 - ICE in gfc_get_function_type

Paul Thomas paulthomas2@wanadoo.fr
Fri Dec 29 15:56:00 GMT 2006


Paul Thomas wrote:
> Dear All,
>>
>>
>> In essence, if we arrive at resolve_function with the function not 
>> already resolved or with the symbol not having FL_UNKNOWN then, for 
>> sure and certain, we are going to produce the ICE in 
>> gfc_get_function_type.  Initially, I had the test only detect 
>> FL_VARIABLE to throw the error.  However, the opening block in 
>> resolve_symbol treats FL_UNKNOWN and results in them either being 
>> identified as variables or procedures.  Thus I think that it is 
>> sufficient to test that the symbol is not a function and that testing 
>> for FL_UNKNOWN adds the belt and braces.
>>
> Cancel this for an hour or two.  The initial version got regtested 
> instead of this one - it is fine, so I might just resubmit that one.  
> However, if I can find the problem with this version I would rather do 
> that.
>
It just seems to be the first version that checks if the symbol is a 
variable that works.  As far as I can tell, all the cases that are going 
to cause the ICE are shunted this way, so this should be an all 
embracing fix.

OK for trunk and 4.2?

Paul



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: Change.Logs
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20061229/ca644833/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr24325.diff
Type: text/x-patch
Size: 1364 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20061229/ca644833/attachment.bin>


More information about the Gcc-patches mailing list