[fortran, patch] Fix handling of printf-style position specifiers of the form "%3$d" in error.c (PR29711)

Jerry DeLisle jvdelisle@verizon.net
Thu Dec 7 01:37:00 GMT 2006


Tobias Burnus wrote:
> :ADDPATCH fortran:
> 
> This is a simple fix of something which got broken between the initial
> patch (attachment to PR29711) and the committed version.
> 
> Attached patch to PR:
> 
> +         while (ISDIGIT(*format))
> +           format++;
> +         format++;
> 
> 
> Checked in patch
> 
>           while (ISDIGIT(*format))
> 
>           /* Skip over the dollar sign.  */
>           format++;
> 
> 
> The fix is simple.
> 
> 2006-12-07  Tobias Burnus  <burnus@net-b.de
> 
> 	PR fortran/29711 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29711>
>         * error.c (error_print): Fix handling of printf-style position specifiers
>         of the form "%3$d".
> 
> 
> 
> Index: gcc/fortran/error.c
> ===================================================================
> --- gcc/fortran/error.c (Revision 119599)
> +++ gcc/fortran/error.c (Arbeitskopie)
> @@ -549,6 +549,7 @@
>         {
>           /* This is a position specifier.  See comment above.  */
>           while (ISDIGIT(*format))
> +           format++;
> 
>           /* Skip over the dollar sign.  */
>           format++;
> 
Is there a test case for this condition?   Or putting it another way, is there a 
test case that did not catch the problem that should be fixed?

Otherwise OK

Jerry



More information about the Gcc-patches mailing list