[PATCH] Fix part of pr25505
Thu Aug 31 19:00:00 GMT 2006
> Ahh - got it. So you're suggesting that I fix the previous logic, too.
> I was a bit hesitant because I wasn't clear on what the LHS could be
> that wasn't a "simple decl", and so I didn't feel confident rewriting
> this portion.
Yeah, it is a bit confusing as to what FOR_EACH_SSA_DEF_OPERAND will
hand you but, AFAIK, it will only hand you SSA_NAMES.
> So, IIUC you're recommending changing the "existing logic" to:
> FOR_EACH_SSA_DEF_OPERAND (def_p, stmt, op_iter, SSA_OP_ALL_DEFS)
> tree def = DEF_FROM_PTR (def_p);
> def = SSA_NAME_VAR (def);
> if (MTAG_P (def) && is_call_clobbered (def))
> goto unsafe;
> OK with those changes if all tests pass?
I can't approve it (i've copied it to diego, who can), but it's got my vote
> - Josh
More information about the Gcc-patches