[PATCH] one-liner: deinline gcc/tree-vrp.c vrp_int_const_binop()

Denis Vlasenko vda.linux@googlemail.com
Sat Aug 12 14:44:00 GMT 2006


On Saturday 12 August 2006 16:02, Zdenek Dvorak wrote:
> Helo,
>
> > * tree-vrp.c (vrp_int_const_binop): deinline it
> 
> please follow the conventions regarding the format of changelog
> messages.

Like this?

2006-08-12 Denis Vlasenko <vda.linux@googlemail.com>

        * tree-vrp.c (vrp_int_const_binop): deinline it
     
Should I put a tab there or spaces? Exactly 8 spaces?
Do I need to have empty lines, where, and how many?

http://www.gnu.org/prep/standards/standards.html
is not consistent about it.

> > There are two dozens of calls to that function.
> > Before/after code size comparison:
> > 
> > # size tree-vrp_inline.o tree-vrp_noinline.o
> >    text    data     bss     dec     hex filename
> >   47147      52      24   47223    b877 tree-vrp_inline.o
> >   44273      52      24   44349    ad3d tree-vrp_noinline.o
> > 
> > This patch was compile-tested.
> 
> even trivial patches like this need full bootstrap and regtesting.  The
> reason is that even though this change is obviously harmless, it might
> uncover some latent bug (the things will be optimized differently
> depending on whether vrp_int_const_binop is inlined or not).
--
vda



More information about the Gcc-patches mailing list