[PATCH] Fix objc_push_parm

Mike Stump mrs@apple.com
Mon Apr 17 20:37:00 GMT 2006


On Apr 6, 2006, at 9:05 AM, Jakub Jelinek wrote:
> Ok for trunk/4.1?
>
> 2006-04-06  Jakub Jelinek  <jakub@redhat.com>
>
> 	* objc-act.c (objc_push_param): If changing type, run relayout_decl
> 	on the parameter.
>
> 	* objc/compile/20060406-1.m: New test.

We were using:

   /* APPLE LOCAL begin 4209854 */
   /* Decay arrays and functions into pointers.  */
   tree type = objc_decay_parm_type (TREE_TYPE (parm));

   /* If the parameter type has been decayed, a new PARM_DECL needs  
to be
      built as well.  */
   if (type != TREE_TYPE (parm))
     parm = build_decl (PARM_DECL, DECL_NAME (parm), type);
   /* APPLE LOCAL end 4209854 */


in our branch (see branches/apple-local-200502-branch for example).   
I think I like that more, given the other 2 spots that we decay.  See  
any problems or issues doing it that way?



More information about the Gcc-patches mailing list