PATCH: PR c/26993: fix weakref ICE on malformed input

Alexandre Oliva aoliva@redhat.com
Wed Apr 5 18:16:00 GMT 2006


On Apr  5, 2006, Jakub Jelinek <jakub@redhat.com> wrote:

> On Wed, Apr 05, 2006 at 01:33:50AM -0300, Alexandre Oliva wrote:
>> This patch fixes a bug introduced when weakrefs switched from extern
>> to static, so it only affects the trunk.  Bootstrapped on
>> amd64-linux-gnu.  Ok to install?

> Can you put the testcase in gcc.dg after adding some dg-* markups to it?

I considered doing that, but decided not to because it would be too
fragile.  The test relies on the fact that the parser does error
recovery in a very particular way, turning a (humanly-obvious)
missing-semicolon error into multiple complains about a (K&R) argument
declaration.  I figured we'd be better off no relying on that.

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Secretary for FSF Latin America        http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}



More information about the Gcc-patches mailing list