[patch] Fix PR 23439/23440

Volker Reichelt reichelt@igpm.rwth-aachen.de
Fri Sep 16 20:50:00 GMT 2005


On 16 Sep, Ian Lance Taylor wrote:
> Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:
> 
>> Apart from "SET_EXPR_LOCUS (node, NULL);" vs. "return;" I fail
>> to see a real difference between this and my version.
> 
> There isn't one.  I was more answering Daniel's comment than your
> patch.

This cosmetic change won't make Daniel happy, I suppose.
I guess, Daniel (and me) meant the parsers by callers of
annotate_with_file_line. The patchlet from
  http://gcc.gnu.org/ml/gcc-patches/2005-09/msg00950.html
looks more tailored to Dan's wishes, I think.

Upon closer inspection this also looks more appealing to me:
No special casing for UNKNOWN_LOCATION!
I'll try to come up with a complete patch.

> I think my suggestion is slightly more consistent with
> --enable-mapped-location, which I expect to become the default.  I
> would prefer to see that consistency, one way or another.  This is
> also what I said in my initial reply a few days ago, of course.

Right. I didn't get that the first time, sorry.

Btw, thanks for catching the borked ChangeLog.

Regards,
Volker




More information about the Gcc-patches mailing list