[patch,fix, PING] PR21875 Internal Array IO and NIST final fix

[Steven Bosscher]

On Tuesday 13 September 2005 21:55, Jerry DeLisle wrote:
> Attached is revised patch for internal unit array I/O
>
> This revision affects only the frontend patches which are attached with new
> test cases.
>
> (
> See http://gcc.gnu.org/ml/fortran/2005-09/msg00176.html for frontend patch
> to trans-io.c
> )
>
> Significant changes relate to checking for contiguous array sections and
> adding error messages for bad arrays and end of file condition.
>
> I would like to request we try to get this into 4.0.2 since it resolves
> significant deficiencies in NIST, and other test suites.
>
> Regression tested OK, NIST tested OK
>
> OK for 4.1?

There are some formatting errors (space after "(int)" in next_record_w,
wrongly indented "for" in get_array_unit_len, and some in mem_alloc_w_at)
but it looks OK to me otherwise.  And you're the library gurus by now
anyway... ;-)

The only surprising bit is this:
+   if (*len < 0)  /* This should never happen */
+     *len = 0;
+ 
So if it never happens, why have it?

The front-end bits from the patch are OK.

> 4.0.2 if approved by Mark? 

I agree it would be good to have this in 4.0 also, but it is probably
too late for 4.0.2 by now.  I have added Mark to the CC:.

Gr.
Steven