[Patch, gfortran] PR22304, 17917, 16511, 18870 and 23270 - modules, equivalences and commons - final(?) version

[Paul Thomas]

Tobi,

>
>Here and in gfc_match_equivalence, you show this peculiar way of arranging the
>commas.  Please put them on the preceding line.
>
OK

> I believe the call to gfc_match_variable is an error. It looks like you're
>
>allowing something like
>   EQUIVALENCE(A(5)B(3),C)
>silently ignoring the syntax error, only adding b and c to the equivalence.
>
Indeed.  I am not sure I know how or why it can work! It does 
though....  I will correct and recheck that all is well.

> I don't think having gfc_match_equiv_variable with a parameter 
> "equiv_flag"
>
>makes much sense.  Either name the function gfc_match_local_variable (or
>something which expresses "not host-associated" more clearly), if you think
>there might be other uses for this function, or do away with equiv_flag, as it
>will always be set.
>
OK

>
>Otherwise I think this patch is ok.
>
As always, many thanks, Tobi.

I will correct, bubblestrap and regtest before doing anything with the 
patch.

Paul