[PATCH, libgfortran] Remove generate_error from mem_alloc_w_at and clean up

Jerry DeLisle jvdelisle@verizon.net
Fri Oct 7 08:37:00 GMT 2005


Janne Blomqvist wrote:
> 
> Typo at (1). Also, you don't need to change unformatted_write() at
> all, since your patch doesn't actually change the behaviour of the
> function. The original
> 
> if (p != NULL)
>     memcpy (...)
> } /* end of function.  */
> 
> is equivalent with your
> 
> if (p == NULL)
>     return;
> memcpy (...)
> } /* end of function.  */
> 
> Finally, the file name shouldn't be mentioned multiple times in the
> changelog. Just start a new sentence with "(function_name):".
> 

Yes you are correct, I blew right over that.  I will fix Changelog and undo the 
unformatted_write change.

Thanks,

Jerry



More information about the Gcc-patches mailing list