[PATCH] fortran/25106 -- Statement labels are nonzero.

Steve Kargl sgk@troutmask.apl.washington.edu
Sun Nov 27 23:13:00 GMT 2005


On Sun, Nov 27, 2005 at 11:21:26PM +0100, FX Coudert wrote:
> >As we discussed on IRC, I think the match routine needs to have exit so 
> >that the parser could recover in some cases (although I can think of no 
> >case involving this, just to be on the safe side). Moreover, no function 
> >in match.c currently calls gfc_error_now, so I think it's better to keep 
> >it that way.
> >
> >Here is another proposition for a patch, based on yours. Passes 
> >regtesting on i686-linux. What do you think of it?
> 
> And of course, I forgot the actual patch.

OK.  I see the amount of duplicate code is really only
something like 5 lines.  I can't think of a situation
where this should fail.  Your patch also removes more
lines of code than my patch.  Go ahead and commit to
mainline (and 4.1 after regtesting).

-- 
Steve



More information about the Gcc-patches mailing list