Patch: bad code for long long inside packed struct

Ian Lance Taylor ian@airs.com
Mon Nov 14 23:49:00 GMT 2005


Dale Johannesen <dalej@apple.com> writes:

> Here's a case with long long inside a packed struct where
> bad code is generated.   Both load and store code are wrong.
> The trouble seems to be in the tree-to-RTL conversion.
> Regtested Darwin ppc.  OK?
> 
> 2005-11-13  Dale Johannesen  <dalej@apple.com>
> 
>          * expmed.c (store_bit_field):  Add offset unconditionally for
>          memory targets.
>          (extract_bit_field):  Don't force extzv or extv operand into
>          a register if field is too big.

This is OK.  Make sure your line lengths are less than 80
characters--the ones in extract_bit_field look too long.

>   2005-11-13  Dale Johannesen  <dalej@apple.com>
> 
>          * gcc.c-torture/execute/20051113-1.c:  New.

Please change the test case to not #include <stdlib.h>, and to not
call calloc.  Neither seems required, and it helps to keep test cases
as standalong as possible.

Thanks.

Ian



More information about the Gcc-patches mailing list