Committed: skip gcc.dg/pr19340.c for some non-scheduling targets.

Hans-Peter Nilsson hans-peter.nilsson@axis.com
Mon Nov 14 01:05:00 GMT 2005


This new test fails for targets that don't schedule, because for
them, gcc emits a warning like so (gcc.log):
...
output is:
x/gcc/testsuite/gcc.dg/pr19340.c:1: warning: instruction scheduling not supported on this target machine
FAIL: gcc.dg/pr19340.c (test for excess errors)
...
(The test machinery doesn't prune that warning and treats
unmarked warnings as failure.)

A better change (target-specific markup frowned-upon for
maintenance-reasons) would of course be to add a specifier like
{ target scheduling } and a corresponding function in
target-supports.exp.  But I don't expect many more of these
generic test to have scheduling options applied.  And I'd have
to wait for approval. :-]

It is perhaps a matter of debate whether those option *should*
cause warnings.  They are different to -fpic/-fPIC (for which
*some* targets that don't support it emit warnings IMO correctly
but not the generic machinery), because -fsched* doesn't change
anything like that: the generated code works the same way and
can be linked together with other code *regardless* of that
option.  Anyway.

testsuite/
	* gcc.dg/pr19340.c: Skip for mmix-*-* and cris-*-*.

Index: pr19340.c
===================================================================
--- pr19340.c	(revision 106861)
+++ pr19340.c	(working copy)
@@ -1,5 +1,6 @@
 /* { dg-do compile } */
 /* { dg-options "-O1 -fschedule-insns2 -fsched2-use-traces" } */
+/* { dg-skip-if "No scheduling" { mmix-*-* cris-*-* } { "*" } { "" } } */
 
 extern double f (double x);
 
brgds, H-P



More information about the Gcc-patches mailing list