darwin unused broken in C++

Andrew Pinski pinskia@physics.uc.edu
Thu Nov 10 18:19:00 GMT 2005


> This fixes:
> 
> void foo(int x) {
> #pragma unused ( x )
> }
> 
> Ok?

A couple of comments
> --- ./ChangeLog.~1~	2005-11-10 09:15:38.000000000 -0800
> +++ ./ChangeLog	2005-11-10 10:05:26.000000000 -0800
> @@ -1,3 +1,10 @@
> +2005-11-10  Mike Stump  <mrs@apple.com>
> +
> +	* c-decl.c (lookup_name_two): Add.
> +	* c-tree.h (lookup_name_two): Likewise.
> +	* c-common.c (handle_cleanup_attribute): Use lookup_name_two instead.
> +	* config/darwin-c.c (darwin_pragma_unused): Likewise.
> +
>  2005-11-10  Eric Botcazou  <ebotcazou@libertysurf.fr>
>  
>  	PR middle-end/22127

You know that we like the changelog not part of the diff right?

> --- ./testsuite/g++.old-deja/g++.mike/unused.C.~1~	2005-11-10 09:47:06.000000000 -0800
> +++ ./testsuite/g++.old-deja/g++.mike/unused.C	2005-11-10 10:06:49.000000000 -0800
> @@ -0,0 +1,7 @@
> +// { dg-do compile { target *-*-darwin* } }
> +// { dg-options { -Wunused-parameter } }
> +// Radar 4125055
> +
> +void foo(int x) {
> +#pragma unused ( x )

New tests should not go into g++.old-deja.  This test belongs in g++.dg/warn.

-- Pinski



More information about the Gcc-patches mailing list