[PATCH] Don't use slowcompare method unconditionally

Andrew Pinski pinskia@physics.uc.edu
Wed Nov 9 15:42:00 GMT 2005


> 
> Hi!
> 
> The http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00547.html
> patch to avoid tail +16c hasn't moved on and the problem that GCC
> doesn't build with unpatched recentish coreutils survives.
> 
> The following patch presents just partial solution, but is already
> sufficient for the GNU coreutils case.
> 
> Before the
> http://gcc.gnu.org/ml/gcc-patches/2005-05/msg01800.html
> patch make bootstrap was using just the detected method for comparisons,
> while after that patch we are using the slowcompare method unconditionally
> for checksum and libgcc objects.  This patch rearranges it so that
> the chosen comparison method is used always and only when it fails, in
> common code it detects whether an error or just a warning should be
> reported.
> 
> Tested with make gnucompare, make fastcompare and make slowcompare,
> each time with objects from a bootstrap, then with one . dir object modified
> by hand and then with one libgcc/ dir object modified.
> 
> Ok for HEAD?

Coreutils has already been fixed.  So why is this patch needed?


-- Pinski



More information about the Gcc-patches mailing list