[Patch] MIPS: three V2SF RTL patterns

[Richard Henderson]

On Tue, Nov 01, 2005 at 11:32:52AM -0800, Chao-ying Fu wrote:
> +extern bool mips_expand_fp_vector_minmax (int, rtx[]);

You don't use the return value, so why return anything?

> +bool mips_expand_fp_vcond (rtx operands[])

Return after bool.

> +  {
> +  case UNORDERED:
...
> +  default:
> +    return false;
> +  }

Indentation +2 here.

> +/* Expand floating-ponit vector smin/smax patterns.

Typo.

> +   minmax is 0 for the smin pattern, and 1 for the smax pattern.  */
> +
> +bool mips_expand_fp_vector_minmax (int minmax, rtx operands[])

Would be clearer as "bool is_max".

> +  emit_insn (gen_mips_cond_move_tf_ps (operands[0], operands[1],
> operands[2],
> +           cmp_result));

Wrapping and indentation.


r~