gcc.dg/compat/struct-layout-1.exp does not supported installed-compiler testing

Mark Mitchell mark@codesourcery.com
Tue May 17 00:27:00 GMT 2005


Ian Lance Taylor wrote:

>>1. Remove the use of config.h and HAVE_*_H.
>>
>>2. Modify the generator not to depend on libiberty headers, including
>>hashtab.h, by substituting a simple dictonary object.
>>
>>3. Adjust struct-layout-1.exp accordingly.
>  
> This is what I would recommend anyhow.

Done with the attached patch.  Tested on x86_64-unknown-linux-gnu by 
comparing the generated files with and without the patch, as well as by 
running the testsuite.  The time taken to run the struct layout tests 
(including their generation) was not measurably different before and 
after the change.  Applied to 4.0 and mainline.

I cribbed a bit from libiberty, but didn't take all of hashtab.c, as 
that just seemed excessive.

Please report any problems to me, of course.

(There's still a POSIX-ism in the generator, in that it tries to write 
to "/dev/null".  On Windows systems, I bet this will often work, but 
create a real file with that name.  It would be better, and avoid 
portability problems, to guard the calls to fwrite, etc., with "if 
(file)" rather than spew to "/dev/null", but that's for another day.)

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: testsuite.compat.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20050517/545ad026/attachment.ksh>


More information about the Gcc-patches mailing list