assertify mcore

Paolo Bonzini paolo.bonzini@lu.unisi.ch
Fri May 6 13:12:00 GMT 2005


FWIW it looks good to me, only a couple of nits:

> --- 1083,1092 ----
>     rtx out_operands[3];
>     const char * load_op;
>     char buf[256];
> +   int trick;
>   
> !   trick = try_constant_tricks (INTVAL (operands[1]), &x, &y);
> !   gcc_assert (trick == 2);

Call these trick_no as later in the patch?

> !   gcc_unreachable ();
>   
>     return 0;

Remove the return?

> !   gcc_unreachable ();
>     return \"\"; 
>   }")

Likewise.

Paolo



More information about the Gcc-patches mailing list