[PATCH] Fix binutils build problem at FreeBSD (fix warning in getopt.h)
Vladimir Merzliakov
wanderer@rsu.ru
Thu Mar 24 17:36:00 GMT 2005
>> And then I think adding defined(__FreeBSD__) in getopt prototype
>> guarding #ifdef is safe and fix warning.
>
> Sorry, this patch is not OK. It will just lead us down the path of
> increasing the #ifdef over and over again. The question here is why
> HAVE_DECL_GETOPT is not defined.
>
> Looking at gcc, I would say that the binutils configure.in file should
> do the equivalent of gcc_AC_CHECK_DECLS(getopt) to get
> HAVE_DECL_GETOPT defined appropriately.
Ok. I will discuss this at binutils maillist.
Thanks for review.
Vladimir
More information about the Gcc-patches
mailing list