Patch [PPC-Darwin] to fix ICE when Altivec argument is passed to function with no prototype.

Fariborz Jahanian fjahanian@apple.com
Fri Mar 4 15:51:00 GMT 2005


On Mar 3, 2005, at 7:59 PM, Mark Mitchell wrote:

> Fariborz Jahanian wrote:
>> FSF mainline ICEs when vector argument is passed to function with no 
>> prototype. This should be
>> flagged as error (Altivec PIM says so). Bootstrapped, dejagnu testsed 
>> with no regressions.
>> OK for fsf mainline?
>
> No; we should find a way to do this in the front end.  Not only is 
> that more correct in the abstract; it's also the only way that you'll 
> get an error message if RTL is never generated for the call.  (Like, 
> because the function is inlined, or because that function is not 
> emitted into the generated assembly code.)

Some ABIs, including darwin's 64bit ABL allow this. So, this is very 
much target specific. Moving to front-end requires
checking for specific target (and its ABI). My initial patch was in the 
front-end. But because of these issues I moved it to the
ABI specific area that was ICEing.

- fariborz

>
> -- 
> Mark Mitchell
> CodeSourcery, LLC
> mark@codesourcery.com
> (916) 791-8304



More information about the Gcc-patches mailing list