Fix profiling for PIC Thumb code
Daniel Jacobowitz
drow@false.org
Fri Mar 4 15:33:00 GMT 2005
On Fri, Mar 04, 2005 at 09:57:03AM +0000, Richard Earnshaw wrote:
> On Fri, 2005-03-04 at 09:53, Richard Earnshaw wrote:
> > Following a request from Eric Christopher, I've re-reviewed this patch,
> > and on reflection I can't see any reason why it would cause problems on
> > 4.0, so could you install it there too?
Will do.
> >
> > R.
> >
> > [for some reason I was thinking you were trying to remove (PLT) markings
> > unconditionally, not just in thumb mode]
>
> Incidentally, there's a (suspended) PR for this: 3925.
>
> Do you know if there are any other outstanding PLT issues, or can we
> close the PR now?
The original issue in that patch was fixed by Paul over a year ago:
* config/arm/arm.c (arm_output_mi_thunk): In Thumb mode, use
'bx' instead of 'b' to avoid branch range restrictions. Output
the thunk immediately before the thunked-to function.
Since every remaining use of (PLT) is now guarded, the original problem
is fixed. The later discussion, over the use of separate relocations,
is not completely done with; gas doesn't ignore (PLT) completely yet.
It probably should, but let's do that after 2.16.
I'd say we could close it now.
--
Daniel Jacobowitz
CodeSourcery, LLC
More information about the Gcc-patches
mailing list