PATCH: Support nested visibility push

[Daniel Jacobowitz]

On Thu, Mar 03, 2005 at 10:04:46AM -0800, H. J. Lu wrote:
> On Thu, Mar 03, 2005 at 12:53:19PM -0500, Daniel Jacobowitz wrote:
> > On Thu, Mar 03, 2005 at 09:46:24AM -0800, H. J. Lu wrote:
> > > When
> > > 
> > > #pragma GCC visibility push(default)
> > > #pragma GCC visibility pop
> > > 
> > > are used for header file wrappers, we may have more 16
> > > 
> > > #pragma GCC visibility push(default)
> > > 
> > > Currently gcc will fail. This patch tries to support nested visibility
> > > push of the same visibility.
> > 
> > Why not just use a VEC, our convenient pushable data structure?
> > 
> 
> Isn't VEC too heavy weight for that? Unless we can want to support
> unlimited push/pop, I am not sure if it is worth the overhead of VEC.

You have added some unreadable macros and a lot of complexity to
something which will never be performance critical, only so that you
could avoid using a standard data structure; don't do that.  If you use
a VEC no one will ever have to look for bugs in your reimplemented
(and documented) stack.

-- 
Daniel Jacobowitz
CodeSourcery, LLC