PATCH to read-rtl.c

[Andrew Pinski]

On Jun 9, 2005, at 3:04 PM, Gabriel Dos Reis wrote:

> Andrew Pinski <pinskia@physics.uc.edu> writes:
>
> | On Jun 9, 2005, at 2:49 PM, Gabriel Dos Reis wrote:
> |
> | > | really
> | > | the only thing which should be changed instead are the .h files 
> to
> | > | support C++ source files,
> | >
> | > May I remind you that, the current state of the .c sources violates
> | > our own coding convention and therefore needs conversion?
> |
> | Which part is violating what and where is this coding convention
> | documented because I don't see it?
>
>    Avoid the use of identifiers or idioms that would prevent code
>    compiling with a C++ compiler. Identifiers such as new or class,
>    that are reserved words in C++, should not be used as variables or
>    field names. Explicit casts should be used to convert between void*
>    and other pointer types.
>
> Are we going through this debate again, Andrew?  You don't think
> everything has been said?

Look C++ is not everything.  I don't remember this being added, in fact
I don't remember it getting approved, I am looking who approved this
because I know I did not approve of this change;  it is a stupid change
really because compiling C code with the C++ compiler is just a stupid
thing to do.  If you want to add C++ code to the compiler that is a
different story.  Just fix the headers and go on with life.

Also I rather have people fixing bugs instead of making changes like
this because this change is only useful if we ever going to rewrite
the WHOLE GCC sources into C++ which is not the current plan anyways.

-- Pinski