[PATCH] Fix PR23067

Mike Stump mrs@apple.com
Fri Jul 29 00:33:00 GMT 2005


On Jul 26, 2005, at 10:43 AM, Chris Lattner wrote:
> Sorry, you're right.  I forgot to attach the rs6000.c portion.   
> Here's the full patch:
>
>
> 2005-07-26 Chris Lattner <clattner@apple.com>
>
>     PR target/23067
>     * config/rs6000/darwin.h (ADJUST_FIELD_ALIGN): DImode values in  
> structures get 32-bit alignment.
>     * config/rs6000/rs6000.c (rs6000_special_round_type_align):  
> DImode values 64-bit align structs

I don't think this is quite right.  It appears to change the logic  
for aix and linux, which strikes me as wrong.  :-(

If you create darwin_round_type_align... it would be closer.  Ok with  
that change, if you want to do it.

If you have the inclination, would be good to cleanup/contribute all  
of the structure alignment code from the apple branch.  :-)  There  
are plenty of other dark corners that are wrong as well.  :-(



More information about the Gcc-patches mailing list