[patch] Externalize data-ref analysis - part 1
Sebastian Pop
sebastian.pop@cri.ensmp.fr
Tue Jul 19 15:26:00 GMT 2005
Thank you for the patch. I have detected a typo in the following code:
! #define DR_ACCESS_FNS(DR)\
! (DR_TYPE(DR) == ARRAY_TYPE ? \
you certainly mean ARRAY_REF_TYPE and not ARRAY_TYPE, because the
value of DR_TYPE should be in the following enum:
+ enum data_ref_type {
+ ARRAY_REF_TYPE,
+ POINTER_REF_TYPE
+ };
Same error occurs below, probably a cut and paste. Other than these
typos I find the patch ok, unless Daniel has more comments.
If you can replace the occurences of "dot followed by a single space"
with a "dot followed by two spaces" at the end of some sentences in
the comments it would be great.
Thanks again.
Sebastian
More information about the Gcc-patches
mailing list