[PATCH]: PR c/22476 -Wmissing-format-attribute [take 2]

Joseph S. Myers joseph@codesourcery.com
Sat Jul 16 16:14:00 GMT 2005


On Sat, 16 Jul 2005, Kaveh R. Ghazi wrote:

> Ah, in hindsight I see that's what you meant here:
> http://gcc.gnu.org/ml/gcc-patches/2005-07/msg01049.html
> Personally I'd prefer to have -Wmissing-format-attribute imply
> -Wformat rather than warn about it not being set.  But I don't feel
> too strongly.  I'll follow your suggestion about the warning text
> unless you change your mind.

In principle it would be best for the options to be completely 
independent.  That is, check_function_arguments would call 
check_function_format if either option is enabled, and 
check_function_format would then only call check_format_info if -Wformat 
is enabled.  (Plus of course removal of the warning for 
-Wmissing-format-attribute on its own, updating of the documentation 
accordingly, removal of gcc.dg/format/opt-6.c which tests for the warning 
and adding a test that -Wmissing-format-attribute on its own enables the 
current warnings.)

> Actually, Mark decided to give individual component maintainers more
> latitude and discretion to approve patches during stage3.  So you can
> approve this minor change for 4.1 if you are comfortable with the
> code.  I'll post a revised patch shortly, thanks for reviewing.

Is there a reference to the current statement of this?  
http://gcc.gnu.org/ still points to the 2005-05-04 status report.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)



More information about the Gcc-patches mailing list