[Patch, libgfortran] PR16435 and NIST fm908.for

Paul Thomas paulthomas2@wanadoo.fr
Wed Jul 13 20:56:00 GMT 2005


Tobi,

First, thanks for a rapid response and, as usual, constructive remarks.

>>
>>Put these into data_transfer_init.  That would save you the duplication; you
>>could also check for formatted I/O there.
>>
OK

>>    return;
>>  
>>!   if (nspaces > 0)
>>!     memset ((char*)(p + m - nspaces), ' ', nspaces);
>>
>
>&p[m - nspaces], not only does this look simpler to me, you'd need size_t
>otherwise.  I'd also find it clearer if you renamed 'm' to 'len' or 'length'
>as in the rest of the file.
>
OK to both.

>
>Ok with these corrections.
>
OK to the "editting" too....  A bit of excessive British zeal there, 
spoiled by the discovery that even in English English that one only has 
one "t".  Hah!

I had better remove the XFAIL as well, han't I?

Paul





More information about the Gcc-patches mailing list