[patch] tree.c: Fix latent bugs in upper_bound_in_type and lower_bound_in_type.

Mark Mitchell mark@codesourcery.com
Tue Jul 12 07:06:00 GMT 2005


Kazu Hirata wrote:
> Hi Mark,
> 
>>>     * tree.c (upper_bound_in_type): Fix calculations for casting
>>>     to a non-wider signed type and casting a signed value to a
>>>     wider unsigned type.
>>>     (lower_bound_in_type): Fix calculations for casting to a
>>>     non-wider signed type.
>>
>>
>>
>> Ok.
> 
> 
> Is this OK for 4.0.x after appropriate testing?  The original post is at:
> 
> http://gcc.gnu.org/ml/gcc-patches/2005-07/msg00566.html
> 
> According to Andrew Pinski, the problem that my patch above fixes is a 
> regression (PR22360), but I do not have any testcase that triggers the 
> bug although I can trigger the bug with a fix for another bug.  (That 
> is, we have a latent bug here.)

Generally, we require a demonstrable testcase.  If the bug is so obscure 
that we can't find a testcase, then it's probably not worth the risk.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304



More information about the Gcc-patches mailing list