[RFH] - Less than optimal code compiling 252.eon -O2 for x86

Fariborz Jahanian fjahanian@apple.com
Fri Jul 1 18:20:00 GMT 2005


On Jun 30, 2005, at 2:29 PM, Fariborz Jahanian wrote:

>
> On Jun 30, 2005, at 12:47 PM, Steven Bosscher wrote:
>
>
>>
>> Well, maybe so, but it would be a pretty lame workaround.  Why are  
>> you
>> so worried about bugs?  This flag was always disabled at -O1, and we
>> have never seen any bug reports that got fixed with -fforced-mem.   
>> And
>> besides, it is better to fix bugs than to work around them.
>>
>> Making the option a nop, issuing a warning in 4.1 and removing the
>> option completely for gcc 4.2 looks like a very reasonable  
>> approach to
>> me.
>>
>>
>
> OK. This seems to be the consensus and I will prepare a patch base  
> on that.

Here is the patch. Bootstrapped, dejagnu tested on apple-ppc-darwin  
and apple-x86 darwin. Couple of tests which use -fforce-mem are twiked.

OK for fsf mainline?

- fariborz

ChangeLog:

2005-07-01  Fariborz Jahanian <fjahanian@apple.com>

         * doc/invoke.texi: Update -fforce-mem documentation.
         * dojump.c (compare_from_rtx,do_compare_rtx_and_jump): Remove
         code for -fforce-mem.
         * expmed.c: (store_bit_field,store_fixed_bit_field,
         extract_bit_field): Ditto.
         * expr.c: (convert_move): Ditto.
         * optabs.c:  
(expand_binop,expand_twoval_unop,expand_twoval_binop,
          
expand_unop,emit_unop_insn,prepare_cmp_insn,emit_conditional_move,
         emit_conditional_add,expand_float,expand_fix): Ditto.
         * opts.c: (decode_options): Remove setting of flag_force_mem  
flag.
         (common_handle_option): Issue warning when -fforce-mem  
specified.



testsuite:/ChangeLog

2005-07-01  Fariborz Jahanian <fjahanian@apple.com>

         * gcc.dg/20030324-1.c: Remove -fforce-mem option.
         * gcc.dg/980816-1.c: Ditto.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fsf-patch-no-force-mem.txt
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20050701/d1fbec95/attachment.txt>
-------------- next part --------------

- fariborz




More information about the Gcc-patches mailing list