[objc] Patch for PR18408 (Was: Re: Objective-C bugs and GCC releases)

[Alexander Malmberg]

Ziemowit Laski wrote:
> On 24 Jan 2005, at 17.41, Alexander Malmberg wrote:
>> objc/ChangeLog:
>> 2005-01-25  Alexander Malmberg  <alexander@malmberg.org>
>>
>>     * objc-act.c (objc_types_compatible_p): New function.
> 
> Also #include "langhooks-def.h"; please also update Make-lang.in.

objc/Make-lang.in already has:

objc/objc-act.o : objc/objc-act.c \
[snip]
    $(LANGHOOKS_DEF_H) $(HASHTAB_H) c-pragma.h gt-objc-objc-act.h
    ^^^^^^^^^^^^^^^^^^

so if I understand this correctly, I don't need to add anything here.

[snip]
>> +    {
>> +      return c_types_compatible_p (type1, type2);
> 
> 
> If you could put in #ifdef OBJCPLUS for cxx_types_compatible_p() (or 
> whatever it's called), that would be great.

cxx_types_compatible_p is right. Done, although I haven't tested the 
obj-c++ part.

[snip]
> Also, please include the comp-types-7.m test case.

I'm assuming you mean Pinski's test case from the PR.

 > If you get a clean
> bootstrap with no regressions, this patch is fine by me.  Thanks.

Bootstrapped (c,objc) on i686-pc-linux-gnu. 'make check-objc' has no new 
failures, and I've confirmed that comp-types-7.m fails with an unpatched 
compiler.

(Pinski: If this is ok, could you commit it for me?)

objc/ChangeLog:
2005-01-25  Alexander Malmberg  <alexander@malmberg.org>

     * objc-act.c (objc_types_compatible_p): New function.
     * objc-act.h (objc_types_compatible_p): Declare.
     * objc-lang.c (LANG_HOOKS_TYPES_COMPATIBLE_P): Define.

testsuite/ChangeLog:
2005-01-25  Alexander Malmberg  <alexander@malmberg.org>

	* objc.dg/comp-types-7.m: New.

- Alexander Malmberg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: objc-types-comp-2.patch
Type: text/x-patch
Size: 2475 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20050125/a1b226df/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comp-types-7.m
Type: text/x-objcsrc
Size: 314 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20050125/a1b226df/attachment-0001.bin>