[tree-profiling-branch PATCH IPCP extensions + Function cloning
Steven Bosscher
stevenb@suse.de
Tue Jan 11 21:03:00 GMT 2005
On Tuesday 11 January 2005 20:05, Jan Hubicka wrote:
> Otherwise the patch looks fine to me, but I would like to see these few
> issues resolved before applying the patch.
Let me add to this, that you should not need this:
> > + /* Create annotations for a single basic block. */
> > +
> > + static void
> > + create_block_annotation (basic_block bb)
> > + {
> > + /* Verify that the tree_annotations field is clear. */
> > + gcc_assert (!bb->tree_annotations);
> > + bb->tree_annotations = ggc_alloc_cleared (sizeof (struct bb_ann_d));
> > + }
in tree-inline.c, which is already a mess. Don't unnecessarily duplicate
functions. If create_bb doesn't give you a block annotation, that is a
bug. Don't paper it over, fix it.
Gr.
Steven
More information about the Gcc-patches
mailing list