PATCH: Eliminate uses of "sleep" in V3 testsuite
Jonathan Wakely
cow@compsoc.man.ac.uk
Wed Jan 5 16:23:00 GMT 2005
On Wed, Jan 05, 2005 at 07:58:39AM -0800, Mark Mitchell wrote:
> Jonathan Wakely wrote:
> >On Mon, Jan 03, 2005 at 06:07:13PM -0800, Mark Mitchell wrote:
> >
> >
> >>2005-01-03 Mark Mitchell <mark@codesourcery.com>
> >>
> >> * testsuite/testsuite_hooks.cc: Use __throw_exception_again
> >> instead of just throw.
> >
> >
> >"__throw_exception_again;" should be used in place of "throw;" to rethrow
> >an active exception. With -fno-exceptions __throw_exception_again is
> >replaced with an empty string, which is not what's wanted.
>
> I followed existing practice in testsuite_hooks.cc.
>
> For example:
>
> __throw_exception_again
> environment_variable(string("LC_ALL for ") + string(name));
>
> Are you requesting that I make a change to the new code I added, or to
> all the code, or just noting this problem? From the subsequent email,
> it sounds like nobody is expecting me to fix this particuar issue; is
> that a correct interpretation of the situation? (I am of course
> planning to deal with the timeout in 9507.cc, however.)
I didn't realise there were already other files that used
__throw_exception_again like that. Now I know that I have no
comments on your patch. I'll help Paolo fix it throughout v3
if it's still making me lose sleep.
Sorry for the interruption,
jon
--
"Any view of the universe that is not strange is false."
- Neil Gaiman
More information about the Gcc-patches
mailing list