[PATCH] Don't use weak linkage for symbols in COMDAT groups

[Julian Brown]

Andreas Jaeger wrote:
> Julian Brown <julian@codesourcery.com> writes:
> 
> 
>>Mark Mitchell wrote:
>>
>>>Julian Brown wrote:
>>>
>>>
>>>>Hi,
>>>>
>>>>This patch stops entities with vague linkage from being declared as
>>>>ELF weak symbols when HAVE_GAS_COMDAT_GROUP is true. This is mainly
>>>>cosmetic, but could lead to subtle interoperability problems.
>>>>
>>>>Tested with cross to arm-none-eabi.
>>>>
>>>>OK to apply?
>>>
>>>Is there any reason not to do this in elf.h?  It doesn't seem
>>>ARM-specific to me.  Would you try making that change, and testing
>>>on IA32 GNU/Linux as well?  Does anyone see backwards compatibility
>>>problems here?
>>
>>It doesn't lead to any new regressions on HEAD for i686-pc-linux-gnu 
>>with the alteration in config/elfos.h instead.
> 
> I propose to revert this patch since it cannot have been tested on
> i686-linux-gnu with all languages, it breaks e.g. Java bootstrap.

OK, I agree and I will revert the patch immediately. Sorry for the 
breakage, I will be sure to run the testsuite with all languages in the 
future!

Julian

-- 
Julian Brown
CodeSourcery, LLC
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch-4-revert
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20050228/bfb5e14c/attachment.ksh>