[v3 patch] Add std::tr1::shared_ptr

Jonathan Wakely cow@compsoc.man.ac.uk
Wed Feb 23 01:18:00 GMT 2005


On Tue, Feb 22, 2005 at 06:11:04PM +0000, Jonathan Wakely wrote:

> On Tue, Feb 22, 2005 at 11:55:05AM -0500, Daniel Jacobowitz wrote:
> 
> > On Mon, Feb 21, 2005 at 01:16:05PM +0000, Jonathan Wakely wrote:
> > > 
> > > This adds <tr1/memory> which covers section 2.2 of TR1 - smart pointers.
> > > 
> > > The code was taken from Boost with permission of the authors. The
> > > <tr1/memory> header contains code from several Boost headers in one
> > > file, which currently has the copyright statements from all those files.
> > > Someone should check I've done everything I need to in order to add this
> > > code to GCC and that the copyrights are OK.
> > 
> > You've added code with an FSF copyright notice that is "also" copyright
> > other individuals.  Does "permission of the authors" include FSF
> > copyright assignments?  If not, I'm not sure this should be added to
> > libstdc++.
> 
> Hi Daniel,
> 
> The authors were aware I was planning to add the code to GCC and that
> the copyright will be assigned to the FSF (as with all GCC code).

Actually, I've re-read my mail and came across this (I knew I spent a
while looking into it back then):

http://lists.boost.org/MailArchives/boost/msg73199.php

I *didn't* ask for copyright assigments from the authors, as I was under the impression it wasn't necessary.  To quote from that mail:

>>>>>>>>>>>> start

http://www.gnu.org/prep/maintain/maintain.html#Copyright-Notices says:

  For an FSF-copyrighted package, if you have followed the procedures to
  obtain legal papers, each file should have just one copyright holder:
  the Free Software Foundation, Inc. You should edit the file's
  copyright notice to list that name and only that name.

  But if contributors are not all assigning their copyrights to a single
  copyright holder, it can easily happen that one file has several
  copyright holders. Each contributor of nontrivial amounts is a
  copyright holder.

[this seems to be the situation for Boost/SGI/HP code used in GCC - jon]

  In that case, you should always include a copyright notice in the name
  of main copyright holder of the file. You can also include copyright
  notices for other copyright holders as well, and this is a good idea
  for those who have contributed a large amount and for those who
  specifically ask for notices in their names. But you don't have to
  include a notice for everyone who contributed to the file, and that
  would be rather inconvenient. 

<<<<<<<<<<<< end

I thought the copyright notice in the file applies to the derivative
work, not the entire work or the original work. *That* copyright is
assigned to the FSF. All the SGI and HP code in libstdc++ also retains
the original copyrights.

If I'm wrong, or if we need clarification, I'll contact the authors
again.

jon



More information about the Gcc-patches mailing list