[PATCH - ping] Don't unlink /dev/null on darwin
Andrew Pinski
pinskia@physics.uc.edu
Wed Feb 16 14:36:00 GMT 2005
On Feb 15, 2005, at 11:36 PM, Zack Weinberg wrote:
>
> Yes, this one is OK.
>
> zw
>
>> + * mklibgcc.in (vis_hide): Don't use -o /dev/null on the test. On
>> + at least darwin -o /dev/null can result in as unlinking /dev/null.
>> + Use a temp file, vis_temp_file$$.o instead.
>
> Don't provide ChangeLog entries as patches - by the time they get
> around to being applied, they won't match. Just plain text is fine.
>
> Also, we generally don't put the rationale in the ChangeLog, I would
> have written
>
> * mklibgcc.in (vis_hide): Use a temporary object file, not
> -o /dev/null.
I installed this for Peter after asking him on IRC if he needed someone
to install this for him.
Thanks,
Andrew Pinski
More information about the Gcc-patches
mailing list