[PATCH] Fix libdecnumber bootstrap on Tru64 (part 2)
Richard Earnshaw
rearnsha@arm.com
Tue Dec 20 18:36:00 GMT 2005
On Tue, 2005-12-20 at 19:02, Gabriel Dos Reis wrote:
> | On Tue, 20 Dec 2005, Richard Earnshaw wrote:
> | > tolower has EOF as part of its input domain, so I think you should
> | > really make u1 and u2 ints; that's the natural type that a function
>
> I'm not sure I agree with that part: when char is signed, the
> promotion char -> int does not make positive values that originally
> negative. So it appears to me that the cast to (unsigned char) is
> necessary.
>
Hmm, time to dig out the standard. The domain of the is... and to...
functions is defined as the domain of unsigned char + EOF. So it would
seem that Gabby is right. Sorry, Roger, I guess that means your
original patch was correct after all.
R.
More information about the Gcc-patches
mailing list