Ping tree-ssa-operands cleanup patches

Zdenek Dvorak rakdver@atrey.karlin.mff.cuni.cz
Tue Dec 13 22:21:00 GMT 2005


Hello,

> > the patches
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2005-08/msg00868.html
> 
> I'm not sure the code is any clearer with this cleanup (admittedly, this
> is complicated code, and i happen to understand how it works, so i'm
> biased :P).

the point is that there is no reason why add_stmt_operands should handle
addr_exprs.  There is no common code between what this function does for
addr_exprs, and what it does for the normal operands.  Also, on all
places where it is used, it is clear whether the operand passed to it is
addr_expr or decl.

Zdenek

> > http://gcc.gnu.org/ml/gcc-patches/2005-08/msg00836.html
> 
> This one i like, so hopefully diego will approve it.
> 
> I'm always in favor of removing redundant, basically unused flags.
> 
> > 
> > clean up some bits of tree-ssa-operands.c that historically
> > made sense, but now just make the code more complicated.
> > 
> > Zdenek



More information about the Gcc-patches mailing list