off-by-one in get_ident

Gabriel Dos Reis gdr@integrable-solutions.net
Tue Dec 13 20:37:00 GMT 2005


Andrew Pinski <pinskia@physics.uc.edu> writes:

| Wait valid C into valid C++ is not a good idea as it makes the code
| worse
| in terms of coding style.

Not necessarily.  And we had this debate before.  That did not change
the coding conventions.

| My point is that this is valid C and should not change just because it
| is invalid C++.  

I hear you, but we need a better reason not to follow our coding
conventions. 

Writing

     static const char template[] = "gpch.013";

is no less valid code.

| Please don't go about and change random stuff just because
| it is invalid C++.

As you probably may not have noticed, I'm not changing random stuff --
I'm not interested in that and I don't have interest in changing
random stuff. 

-- Gaby



More information about the Gcc-patches mailing list