PATCH: PR libfortran/25305: [4.0 regression]: libfortran failed fma3d in SPEC CPU 2K
Jerry DeLisle
jvdelisle@verizon.net
Thu Dec 8 08:56:00 GMT 2005
H. J. Lu wrote:
> http://gcc.gnu.org/ml/gcc-patches/2005-11/msg00874.html
>
> caused fma3d in SPEC CPU 2K to fail. It has this change:
>
> @ -293,7 +292,7 @@ write_block (int length)
> {
> char *dest;
>
> - if (!is_internal_unit() && current_unit->bytes_left < length)
> + if (current_unit->bytes_left < length)
> {
> generate_error (ERROR_EOR, NULL);
> return NULL;
>
> which wasn't even mentioned in ChangeLog. Reverting it fixed this
> regression.
>
I apologize for missing that in the ChangeLog. I do not have access to SPEC
benchmarks. Could you please check to make sure you do not see this regression
in 4.2. (4.2 has that same change in write_block)
I think the difference is I was not able to get the internal unit array I/O
patch into 4.0 because it needed another patch that had not gone in, etc, etc,
etc. 4.0 is very much out of sync with 4.1 and 4.2. The problem did not show
in regression testing which I always do before committing.
Thanks for fixing in 4.0,
Regards,
Jerry
More information about the Gcc-patches
mailing list