[PATCH] Generalize insert_insn_end_bb()

Steven Bosscher stevenb@suse.de
Tue Aug 30 12:55:00 GMT 2005


On Tuesday 30 August 2005 14:22, Leehod Baruch wrote:
> > Ehm, you're kidding, right?  How can this possibly be useful to
> > anyone outside gcse.c when "struct expr" is also in gcse.c?  And
> > what about the updating of gcse'c local data flow (i.e. that call
> > to record_set_info)?
>
> No, I'm not kidding!
> If you`ll take another look at the patch you`ll see that "struct expr"
> is no longer passed to this function.
> I agree that there is a problem with record_set_info, I didn't noticed
> it, but if the idea will be accepted, this could be fixed easily.

It would be yet another hack.  If you want a general purpose function
you should not hack gcse.c but put that function in a place where it
belongs.

Gr.
Steven



More information about the Gcc-patches mailing list