[PATCH] Revert 2004-06-{05,26} libcpp/files.c performance changes (PRs preprocessor/203{48,56})
Mark Mitchell
mark@codesourcery.com
Tue Aug 30 05:30:00 GMT 2005
Jakub Jelinek wrote:
> Hi!
>
> My understanding was that these changes were meant just as performance
> improvement. But if that performance improvement comes from not including
> the correct files in some situations, IMHO correctness has priority.
>
> Quoting Neil Booth from the bugzilla:
> "I would back it out; I suspect the perceived performance improvement
> came from missing some cases like these. IMO the code was already
> quite efficient."
>
> I guess if somebody cares enough and proves that this optimization is
> fixable, it could be added again, but it is unclear to me whether this
> is fixable or not.
>
> Ok for HEAD/4.0?
OK.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
More information about the Gcc-patches
mailing list