[csl-arm] More combine and deleted insns.

Roger Sayle roger@eyesopen.com
Sat Apr 30 19:05:00 GMT 2005


On Sat, 30 Apr 2005, Paul Brook wrote:
> The attached patch fixes annother case where combine puts notes back onto an
> about-to-be-deleted insn. THis one is harmless, but trips up my assert.
> Applied to csl-arm-branch.
>
> 2005-04-30  Paul Brook  <paul@codesourcery.com>
>
> 	* combine.c (distribute_notes): Don't put REG_EQUAL notes on deleted
> 	insns.

I'm a bit disappointed that you never followed up or responded to my
previous related patch review of your "Combine looses libcall notes"
patch at http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00736.html

If these changes to combine.c are appropriate, they should really also
be applied to mainline.  For example, Ian Lance Taylor's suggestion of
using a suitable macro instead of cryptic PATTERN (insn) != pc_rtx.

For example,

/* Test whether an insn is scheduled for deletion in distribute_notes.  */
#define ZOMBIE_INSN_P(x) (PATTERN (x) == pc_rtx)


Roger
--



More information about the Gcc-patches mailing list