[patch] Missing std qualification in std::rotate_copy

Jonathan Wakely cow@compsoc.man.ac.uk
Mon Apr 18 15:43:00 GMT 2005


Hi y'all,

I think there's a missing std:: qual in rotate_copy, as shown in the
attached patch.

2005-04-18  Jonathan Wakely  <redi@gcc.gnu.org>

	* include/bits/stl_algo.h: Add missing std qualification.

I successfully bootstrapped and regtested on mainline late last week.
Bootstrapped and tested on v7 today, no new FAILs (I'm seeing abi_check
failure and some failures due to concept-checks, but nothing changes
with this patch)

OK to commit to mainline and v7 branch?

Aside: since rotate_copy is just two calls to std::copy, should it be
declared inline?

jon

-- 
"There are perhaps 5% of the population that simply *can't* think.
 There are another 5% who *can*, and *do*.
 The remaining 90% *can* think, but *don't*."
	- R. A. Heinlein
-------------- next part --------------
Index: include/bits/stl_algo.h
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/include/bits/stl_algo.h,v
retrieving revision 1.50
diff -c -r1.50 stl_algo.h
*** include/bits/stl_algo.h	29 Oct 2004 21:44:55 -0000	1.50
--- include/bits/stl_algo.h	13 Apr 2005 13:34:32 -0000
***************
*** 1736,1742 ****
        __glibcxx_requires_valid_range(__first, __middle);
        __glibcxx_requires_valid_range(__middle, __last);
  
!       return std::copy(__first, __middle, copy(__middle, __last, __result));
      }
  
    /**
--- 1736,1743 ----
        __glibcxx_requires_valid_range(__first, __middle);
        __glibcxx_requires_valid_range(__middle, __last);
  
!       return std::copy(__first, __middle,
!                        std::copy(__middle, __last, __result));
      }
  
    /**


More information about the Gcc-patches mailing list