[RFC] [C++ ABI] support non-standard integer types in mangle.c
Mark Mitchell
mark@codesourcery.com
Sun Apr 17 06:54:00 GMT 2005
Markus F.X.J. Oberhumer wrote:
> Mark Mitchell wrote:
>
>> Markus F.X.J. Oberhumer wrote:
>>
>>> ! if (TYPE_UNSIGNED (type))
>>> ! {
>>> ! write_unsigned_number (4 + len);
>>> ! write_string ("uint");
>>> ! }
>>> ! else
>>> ! {
>>> ! write_unsigned_number (3 + len);
>>> ! write_string ("int");
>>> ! }
>>
>>
>>
>> Do this part as:
>>
>> prefix = TYPE_UNSIGNED (type) ? "uint" : "int";
>> write_unsigned_number (strlen (prefix) + len);
>> write_string (prefix);
>>
>> With that change, this patch is OK.
>
>
> As you don't seem to mind an extra strlen() call I've opted for a little
> more clarity. Newly built ILP64 gcc and tested. Please review and apply.
The patch is OK. Do you have a copyright assignment on file?
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
More information about the Gcc-patches
mailing list