[PATCH] Use gcc_assert and gcc_unreachable in the SPARC backend
James A. Morrison
ja2morri@csclub.uwaterloo.ca
Mon Apr 11 17:17:00 GMT 2005
Eric Botcazou <ebotcazou@libertysurf.fr> writes:
> > This patch changes aborts in the SPARC backend to be gcc_asserts or
> > gcc_unreachable. It has been bootstrapped on sparc64-linux and
> > bootstrapped and regtestd on sparc-linux. Ok for mainline?
>
> Two nits: I'd prefer the globally negative form for
>
> + gcc_assert (! LEAF_SIBCALL_SLOT_RESERVED_P || ! final_sequence);
>
Only this place? None of the other !foo && !bar?
--
Thanks,
Jim
http://www.student.cs.uwaterloo.ca/~ja2morri/
http://phython.blogspot.com
http://open.nit.ca/wiki/?page=jim
More information about the Gcc-patches
mailing list