[gfortran] patch PR 17229
Tobias Schlüter
tobias.schlueter@physik.uni-muenchen.de
Fri Apr 8 18:24:00 GMT 2005
Steven Bosscher wrote:
> On Wednesday 06 April 2005 16:55, François-Xavier Coudert wrote:
>
>>+ * *much* easier. */
>>+match
>>+gfc_match_arithmetic_if (void)
>>+{
>
>
> - Missing "static". This causes build failures.
> - Non-GNU coding style for the comment before the function.
Also, please don't prefix static functions with 'gfc_' in the parts of
gfortran which don't interface directly with gcc. (Since gcc doesn't have a
clean naming convention, we put gfc_ on functions in trans-*.c so that if it's
not prefixed by gfc_ there, we know it's in the common source code. At least
that's how I understand the origins of these different conventions.)
- Tobi
More information about the Gcc-patches
mailing list