[PATCH] g++.dg/compat/struct-layout-1 tests

Janis Johnson janis187@us.ibm.com
Tue Apr 5 22:44:00 GMT 2005


On Tue, Apr 05, 2005 at 01:19:21PM -0400, Jakub Jelinek wrote:
> Hi!
> 
> This patch adds a variation on the gcc.dg/compat/struct-layout-1
> tests for C++.  I have removed stuff that was specific to C
> and allowed bitfields larger than their type.  Still, it only
> tests POD types (I was surprised struct S { _Complex int i; }
> is non-POD), for non-POD a different test type will be needed
> (e.g. avoiding vaarg testing etc.).
> 
> On i386/x86-64 this revealed an ICE on 3 of the 30 tests
> I'll be looking into later.
> 
> Unfortunately, as the test is written, did not discover the ABI
> bug in 4.0 with type * __attribute__((...)) class_field;
> because the bug doesn't exist with typedef type * __attribute__((...)) typeattr;
> typeattr class_field;
> Still, it is IMHO worth the extra testing time.
> 
> Ok for HEAD?

Looks good to me unless there are big complaints about extra testing
time.  I ran the tests but didn't pay attention to time, although as
usual I used RUN_ALL_COMPAT_TEST=1.

Janis



More information about the Gcc-patches mailing list