PING edge-vector-branch merge

[Mark Mitchell]

Steven Bosscher wrote:

> Given that you are one of only 12 people who can approve changes
> that touch the entire compiler, and that of those 12, only 2 or 3
> actually review patches outside their own area of interest on a
> regular basis, I really hope you do not stop reviewing patches just
> because "people" "perceive" things.
> Especially when there is clearly no possible conflict of interest
> between this patch and you with any of your non-RM hats on ;-)

I do have a conflict of interest.  We have a customer who has hired us 
to improve compile-time performance.  This patch, and the follow-on 
patches that you mention, would help that customer, and thereofre 
CodeSourcery.  Personally, I feel capable of balancing this conflict 
against my obligation as the RM to treat all contributions equally,  but 
I want to avoid even the perception of bias.

> For this particular patch I'd even say you are the *only* person
> qualified to approve or reject the patch because you as the RM
> decided that this project deserved a chance despite the magnitude
> of the change.

I don't think that's true.  As the RM, I decided this project was 
worthwhile, but that doesn't mean that another maintainer would not be 
better or equally able to comment on the particular technical decisions 
made.  Or, in fact, to say "I'm very uncomfortable with this patch; this 
particular part strikes me as very risky; if there is no other way to do 
this, I would recommend that the RM omit this patch."

I will review the patch if nobody else does.  But, I'm hoping that 
someone else will take a look at it first.  If it's not been reviewed by 
Monday, would you please remind me, and I will take a look at it then?

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com