RFA: profile.c USE_MAPPED_LOCATION support

Jan Hubicka hubicka@ucw.cz
Wed Sep 15 19:41:00 GMT 2004


> Hi -
> 
> hubicka wrote:
> 
> > [...]
> > > ! 		  /* ??? source_locus type is marked deprecated in input.h.  */
> > > ! 		  source_locus curr_location = bb->succ->goto_locus;
> > > ! 		  /* ??? The FILE/LINE API is inconsistent for these cases.  */
> > 
> > This means that the goto_locus construct is completely broken by
> > USE_MAPPED_LOCATION?   [...]
> 
> I don't think so, just that the USE_MAPPED_LOCATION and the
> !USE_MAPPED_LOCATION macros in <input.h> are not compatible for
> processing source_locus values directly.  I believe the proposed
> code works for both by specifying suitable macro calls for each
> configuration.  Can you suggest some specific test (other than
> bprob.exp which already ran) to confirm functionality?

brprob.exp looks fine.  Can you please check it also with
-ftree-based-profiling?
If that passes, the patch is OK.

Honza
> 
> - FChE




More information about the Gcc-patches mailing list