PATCH: Add two ObjC++ callback functions to cp/decl.c

[Ziemowit Laski]

On 10 Sep 2004, at 14.25, Mark Mitchell wrote:
>> +
>> +/* The following routine is used by the NeXT-style SJLJ exceptions;
>> +   variables get marked 'volatile' so as to not be clobbered by
>> +   _setjmp()/_longjmp() calls.  */
>>
> You need a better comment.  You've not said what ENCLOSING_BLOCK is, 
> for starters.

OK; I'll check in an elaboration.

>
>> +      for (decl = scope->names; decl; decl = TREE_CHAIN (decl))
>> +        {
>> +          DECL_REGISTER (decl) = 0;
>> +          TREE_THIS_VOLATILE (decl) = 1;
>> +        }
>
> I suspect this can be made to fault; I'm not confident that everything 
> on that list is a VAR_DECL.

I'll add a check for VAR_DECL-ness to make you feel better. :-)

>
> I think you need to get these kinds of patches reviewed and approved.  
> They're not "obvious" just because they "don't affect C++ control 
> flow."

I guess what I meant is that they're obvious from _your_/C++ 
perspective, since C++ execution is not altered by it.  No, I suppose 
they're not obvious from the ObjC++ perspective, but I take full 
responsibility for it as the ObjC++ maintainer. :-)

--Zem